[webkit-reviews] review denied: [Bug 203557] Determine viewport distances for lazy image loading : [Attachment 439729] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 203557: Determine viewport distances for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=203557

Attachment 439729: Patch

https://bugs.webkit.org/attachment.cgi?id=439729&action=review




--- Comment #45 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439729
  --> https://bugs.webkit.org/attachment.cgi?id=439729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439729&action=review

> Source/WebCore/html/LazyLoadImageObserver.cpp:89
> +	   static NeverDestroyed<const String>
lazyLoadingRootMarginFallback(MAKE_STATIC_STRING_IMPL("100% 0px"));
> +	   IntersectionObserver::Init options { std::nullopt,
lazyLoadingRootMarginFallback, { } };

Doesn't this need to account for horizontally scrollable documents? You need to
look at main view scrollability.