[webkit-reviews] review granted: [Bug 231019] [MSE][GStreamer] Honor MP4 edit lists : [Attachment 439726] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 231019: [MSE][GStreamer] Honor MP4 edit lists
https://bugs.webkit.org/show_bug.cgi?id=231019

Attachment 439726: Patch

https://bugs.webkit.org/attachment.cgi?id=439726&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 439726
  --> https://bugs.webkit.org/attachment.cgi?id=439726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439726&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:395
> +    {

Why do you open a scope here? I think you can remove it.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:436
> +	       gst_sample_set_buffer(sample.get(), nullptr);

Do you need to set the buffer to null here if you're going to set it below
again?

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:441
> +	       gst_sample_set_buffer(sample.get(), newBuffer.leakRef());

You're leaking here. gst_sample_set_buffer takes a transfer none buffer.