[webkit-reviews] review granted: [Bug 230977] REGRESSION (r282150): Missing background-color on inline box while hovering : [Attachment 439666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 04:08:36 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 230977: REGRESSION (r282150): Missing background-color on inline box while
hovering
https://bugs.webkit.org/show_bug.cgi?id=230977

Attachment 439666: Patch

https://bugs.webkit.org/attachment.cgi?id=439666&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 439666
  --> https://bugs.webkit.org/attachment.cgi?id=439666
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439666&action=review

> Source/WebCore/rendering/RenderInline.cpp:194
> +	       if (auto* container =
LayoutIntegration::LineLayout::blockContainer(*this); container &&
shouldInvalidateLineLayoutPath)
>		   container->invalidateLineLayoutPath();

you could get the block via lineLayout->flow() too (and it doesn't need to be
null tested).


More information about the webkit-reviews mailing list