[webkit-reviews] review granted: [Bug 231000] Add weakThis check in addition to null check added in r282881 : [Attachment 439686] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 17:49:55 PDT 2021


Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231000: Add weakThis check in addition to null check added in r282881
https://bugs.webkit.org/show_bug.cgi?id=231000

Attachment 439686: Patch

https://bugs.webkit.org/attachment.cgi?id=439686&action=review




--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 439686
  --> https://bugs.webkit.org/attachment.cgi?id=439686
Patch

This patch isn't about verifying the string returns the right thing.

Putting the log line before start() makes it categorically false, as start()
may not actually *start*


More information about the webkit-reviews mailing list