[webkit-reviews] review granted: [Bug 230969] [GTK][WPE] Enable bwrap launcher build on bots : [Attachment 439626] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 230969: [GTK][WPE] Enable bwrap launcher build on bots
https://bugs.webkit.org/show_bug.cgi?id=230969

Attachment 439626: Patch

https://bugs.webkit.org/attachment.cgi?id=439626&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 439626
  --> https://bugs.webkit.org/attachment.cgi?id=439626
Patch

Ehh, I can't decide if this is a good change or not. It seems reasonable, so
r=me if you decide to proceed. Here's what I'm thinking: building bubblewrap
sandbox enabled on buildbots and EWS is definitely good to do. We surely want
all tests to run with the sandbox enabled, because they are not meaningfully
testing the code that users actually run otherwise (or, in cases where the
sandbox is not yet enabled, the code that we want users to actually run). So we
surely want to do that. 

The downside is that now we need to modify each downstream flatpak runtime and
each flatpak app that bundles WebKitGTK to build with
-DENABLE_BUBBLEWRAP_SANDBOX=OFF (because bubblewrap will not be available in
these environments, since it is useless under flatpak). That is hardly a big
deal. For the GNOME runtime, it would be a one-line change. It might confuse
some app developers, but hopefully most app developers inherit WebKitGTK from a
runtime instead of building it themselves. So... I think that's OK.

The alternative way to accomplish this would be to enable
-DENABLE_BUBBLEWRAP_SANDBOX at the buildbot config or build-webkit level rather
than here in CMake. Modifying the config of every bot would be annoying, but
perhaps this could be something that build-webkit just knows to pass, because
build-webkit is the one special time that we want to build with bubblewrap
sandbox enabled inside a flatpak environment?

Whatever. Your call.