[webkit-reviews] review granted: [Bug 230814] Thin hairline gap displayed for subpixel sized inset box-shadows : [Attachment 439629] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 230814: Thin hairline gap displayed for subpixel sized inset box-shadows
https://bugs.webkit.org/show_bug.cgi?id=230814

Attachment 439629: Patch

https://bugs.webkit.org/attachment.cgi?id=439629&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439629
  --> https://bugs.webkit.org/attachment.cgi?id=439629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439629&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2547
> +	       auto snappedShadowOffset = FloatSize {
roundToDevicePixel(shadowOffset.width(), deviceScaleFactor),
roundToDevicePixel(shadowOffset.height(), deviceScaleFactor) };

Use `roundSizeToDevicePixels(const LayoutSize...)`