[webkit-reviews] review denied: [Bug 230919] Add telemetry to the Networking process sandbox : [Attachment 439526] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 230919: Add telemetry to the Networking process sandbox
https://bugs.webkit.org/show_bug.cgi?id=230919

Attachment 439526: Patch

https://bugs.webkit.org/attachment.cgi?id=439526&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 439526
  --> https://bugs.webkit.org/attachment.cgi?id=439526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439526&action=review

It looks like you have a bad merge in this patch. Could you please rebase it?

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55
> +(allow file-map-executable (with telemetry)

Did you mean to do telemetry for the Private Frameworks paths? Or just
everything else?

>
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415
> +<<<<<<< .mine

Uh oh! Bad merge!