[webkit-reviews] review denied: [Bug 230954] Make WebLocalizedString() thread-safe : [Attachment 439607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 08:37:04 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 230954: Make WebLocalizedString() thread-safe
https://bugs.webkit.org/show_bug.cgi?id=230954

Attachment 439607: Patch

https://bugs.webkit.org/attachment.cgi?id=439607&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 439607
  --> https://bugs.webkit.org/attachment.cgi?id=439607
Patch

Seems like a bad idea to me. This assertion caught thread safety bug in
important clients several times in recent memory.

One could claim that we shouldn't care because those re client bugs not WebKit
ones; I will not agree with that.


More information about the webkit-reviews mailing list