[webkit-reviews] review denied: [Bug 225070] Only link WTF from JavaScriptCore and only link PAL from WebCore in Mac CMake build : [Attachment 439569] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has denied  review:
Bug 225070: Only link WTF from JavaScriptCore and only link PAL from WebCore in
Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=225070

Attachment 439569: Patch

https://bugs.webkit.org/attachment.cgi?id=439569&action=review




--- Comment #7 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 439569
  --> https://bugs.webkit.org/attachment.cgi?id=439569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439569&action=review

The _FRAMEWORKS actually computes how to link the frameworks. So in the Mac
case if you were linking WTF it would be linked through JavaScriptCore because
that's the library that exposes WTF.

There may be an issue around making WebCoreTestSupport being SHARED but other
than that it SHOULD work properly after you use OBJECT with bmalloc, WTF, PAL.
If not then there's a bug in the macro with computing it.

> Source/WebKit/CMakeLists.txt:303
> -set(WebKit_FRAMEWORKS
> +set(WebKit_PRIVATE_LIBRARIES
>      JavaScriptCore
> -    PAL
> -    WTF
>      WebCore

This change is incorrect.

> Source/cmake/OptionsMac.cmake:-113
>  set(JavaScriptCore_LIBRARY_TYPE SHARED)
>  set(WebCore_LIBRARY_TYPE SHARED)
> -set(WebCoreTestSupport_LIBRARY_TYPE SHARED)

Please modify things so its

set(bmalloc_LIBRARY_TYPE OBJECT)
set(WTF_LIBRARY_TYPE OBJECT)
set(JavaScriptCore_LIBRARY_TYPE SHARED)
set(PAL_LIBRARY_TYPE OBJECT)
set(WebCore_LIBRARY_TYPE SHARED)

> Tools/TestWebKitAPI/CMakeLists.txt:206
>      set(TestWebCore_FRAMEWORKS
>	   JavaScriptCore
> -	   PAL
> -	   WTF
> -	   WebCore
> +	   WebKit

This change is incorrect.