[webkit-reviews] review granted: [Bug 230947] [CSS Cascade Layers] Add fonts and keyframes in cascade layer order : [Attachment 439599] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 230947: [CSS Cascade Layers] Add fonts and keyframes in cascade layer order
https://bugs.webkit.org/show_bug.cgi?id=230947

Attachment 439599: Patch

https://bugs.webkit.org/attachment.cgi?id=439599&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439599
  --> https://bugs.webkit.org/attachment.cgi?id=439599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439599&action=review

> Source/WebCore/style/RuleSet.cpp:349
> +	   if (is<StyleRuleFontFace>(*rule) ||
is<StyleRuleFontPaletteValues>(*rule) || is<StyleRuleKeyframes>(*rule)) {

Would be nice to have a way to collectively refer to these. Are they just all
the kinds of @ rules we know about? What happens when we add new ones?