[webkit-reviews] review granted: [Bug 204276] Implement the 'ic' unit from CSS Values 4 : [Attachment 439579] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Kiet Ho <tho22 at apple.com>'s
request for review:
Bug 204276: Implement the 'ic' unit from CSS Values 4
https://bugs.webkit.org/show_bug.cgi?id=204276

Attachment 439579: Patch

https://bugs.webkit.org/attachment.cgi?id=439579&action=review




--- Comment #31 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 439579
  --> https://bugs.webkit.org/attachment.cgi?id=439579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439579&action=review

> Source/WebCore/platform/graphics/Font.h:-138
> -    FontMetrics& fontMetrics() { return m_fontMetrics; }

Are these unused?

>
LayoutTests/imported/w3c/web-platform-tests/css/css-values/ic-unit-001-expected
.html:-6
> -svg { width: 10ic; }

Are these being updated upstream too?