[webkit-reviews] review granted: [Bug 230921] [LFC][IFC] Layout::Box should be able to return the first-line style when applicable : [Attachment 439540] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 230921: [LFC][IFC] Layout::Box should be able to return the first-line
style when applicable
https://bugs.webkit.org/show_bug.cgi?id=230921

Attachment 439540: Patch

https://bugs.webkit.org/attachment.cgi?id=439540&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 439540
  --> https://bugs.webkit.org/attachment.cgi?id=439540
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439540&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:78
> +	   std::unique_ptr<RenderStyle> firstLineStyle;
> +	   if (childRenderer.style() != childRenderer.firstLineStyle())
> +	       firstLineStyle =
RenderStyle::clonePtr(childRenderer.firstLineStyle());

I think this can even do faster

if (&renderer.style() != &renderer.firstLineStyle())

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:167
> +	   if (renderer.style() != renderer.firstLineStyle())

This too