[webkit-reviews] review granted: [Bug 230252] [css-grid] Accommodate spanning items crossing flexible tracks : [Attachment 438646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 01:21:21 PDT 2021


Sergio Villar Senin <svillar at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 230252: [css-grid] Accommodate spanning items crossing flexible tracks
https://bugs.webkit.org/show_bug.cgi?id=230252

Attachment 438646: Patch

https://bugs.webkit.org/attachment.cgi?id=438646&action=review




--- Comment #10 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 438646
  --> https://bugs.webkit.org/attachment.cgi?id=438646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438646&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:556
> +    for (uint32_t i = tracksSize; i-- > 0;) {

seems like you didn't change this


More information about the webkit-reviews mailing list