[webkit-reviews] review denied: [Bug 230778] PCM: Take app bundle ID into consideration when matching triggering events with pending clicks : [Attachment 439544] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied John Wilander
<wilander at apple.com>'s request for review:
Bug 230778: PCM: Take app bundle ID into consideration when matching triggering
events with pending clicks
https://bugs.webkit.org/show_bug.cgi?id=230778

Attachment 439544: Patch

https://bugs.webkit.org/attachment.cgi?id=439544&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 439544
  --> https://bugs.webkit.org/attachment.cgi?id=439544
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439544&action=review

> Source/WebCore/loader/PrivateClickMeasurement.cpp:152
> +    RELEASE_ASSERT(WebCore::applicationBundleIdentifier() ==
"com.apple.WebKit.WebKitTestRunner"_s);

iOS has a different bundle ID, "org.webkit.WebKitTestRunnerApp"

> Source/WebCore/loader/PrivateClickMeasurement.h:424
> +    std::optional<String> m_sourceApplicationBundleIDForTesting;

I don't think this needs to be stored separately on the PCM. 
setSourceApplicationBundleIDForTesting could just set
m_sourceApplicationBundleID.

> Source/WebKit/NetworkProcess/NetworkSession.h:217
> +    std::optional<String> m_privateClickMeasurementAppBundleIDForTesting;

This should probably be stored on the PrivateClickMeasurementManager along with
all the other testing state.