[webkit-reviews] review granted: [Bug 230915] DoesGCCheck does not use enough bits for nodeIndex : [Attachment 439534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 16:09:59 PDT 2021

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 230915: DoesGCCheck does not use enough bits for nodeIndex

Attachment 439534: Patch


--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 439534
  --> https://bugs.webkit.org/attachment.cgi?id=439534

View in context: https://bugs.webkit.org/attachment.cgi?id=439534&action=review

r=me with fix.

> Source/JavaScriptCore/dfg/DFGDoesGCCheck.h:79
> +    unsigned nodeOp() { return u.other & nodeOpMask; }

This should be:
    unsigned nodeOp() { return (u.other >> nodeOpShift) & nodeOpMask; }

More information about the webkit-reviews mailing list