[webkit-reviews] review granted: [Bug 230913] Allow `DrawGlyphsRecorder` to be used with any `GraphicsContext` instead of just `DisplayList::Recorder` : [Attachment 439530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 15:23:35 PDT 2021

Myles C. Maxfield <mmaxfield at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 230913: Allow `DrawGlyphsRecorder` to be used with any `GraphicsContext`
instead of just `DisplayList::Recorder`

Attachment 439530: Patch


--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 439530
  --> https://bugs.webkit.org/attachment.cgi?id=439530

View in context: https://bugs.webkit.org/attachment.cgi?id=439530&action=review

> Source/WebCore/platform/graphics/GraphicsContext.h:358
> +    virtual const GraphicsContextState& lastStateChange() const { return
state(); }

Still don't like the word "change"

> Source/WebCore/platform/graphics/GraphicsContext.h:477
> +	   drawGlyphs(font, glyphs, advances, numGlyphs, point,

If all the arguments are identical, why doesn't DrawGlyphsRecorder just call
drawGlyphs() instead of this renamed function?

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:153
> +const GraphicsContextState& Recorder::lastStateChange() const


> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:97
> +    const GraphicsContextState& lastStateChange() const final;


More information about the webkit-reviews mailing list