[webkit-reviews] review granted: [Bug 230917] Crash in Crash in WebKit::DisplayLink::displayLinkCallback() : [Attachment 439521] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230917: Crash in Crash in WebKit::DisplayLink::displayLinkCallback()
https://bugs.webkit.org/show_bug.cgi?id=230917

Attachment 439521: Patch

https://bugs.webkit.org/attachment.cgi?id=439521&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 439521
  --> https://bugs.webkit.org/attachment.cgi?id=439521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439521&action=review

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:51
> -	   WTFLogAlways("Could not create a display link for display %u: error
%d", displayID, error);
> +	   WTFLogAlways("DisplayLink: Could not create a display link for
display %u: error %d", displayID, error);

Is this disastrous enough that it should be a simulated crash?