[webkit-reviews] review requested: [Bug 230853] Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h : [Attachment 439497] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 11:16:38 PDT 2021


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 230853: Build-time optimization: forward declare more things in
MediaPlayer.h and HTMLMediaElement.h
https://bugs.webkit.org/show_bug.cgi?id=230853

Attachment 439497: Patch

https://bugs.webkit.org/attachment.cgi?id=439497&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Created attachment 439497

  --> https://bugs.webkit.org/attachment.cgi?id=439497&action=review

Patch

Reverted the change to RefPtr, as other compilers still throw errors for
"RefPtr<Foo> foo() { return nullptr ; }" when Foo is forward-declared.


More information about the webkit-reviews mailing list