[webkit-reviews] review granted: [Bug 213903] [WebAuthn] authenticators supporting internal uv and pinToken defaulting to client pin : [Attachment 439105] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 213903: [WebAuthn]	authenticators supporting internal uv and pinToken
defaulting to client pin
https://bugs.webkit.org/show_bug.cgi?id=213903

Attachment 439105: Patch

https://bugs.webkit.org/attachment.cgi?id=439105&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 439105
  --> https://bugs.webkit.org/attachment.cgi?id=439105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439105&action=review

r=me, but please include the radar in your changeling.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=213903

Please always include the radar: <rdar://problem/65359269>

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=213903

Ditto.

> Tools/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=213903

Ditto.