[webkit-reviews] review granted: [Bug 230380] [Cocoa] Support in-band chapter tracks : [Attachment 439419] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 28 08:54:05 PDT 2021
Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 230380: [Cocoa] Support in-band chapter tracks
https://bugs.webkit.org/show_bug.cgi?id=230380
Attachment 439419: Patch
https://bugs.webkit.org/attachment.cgi?id=439419&action=review
--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 439419
--> https://bugs.webkit.org/attachment.cgi?id=439419
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=439419&action=review
r=me with nits and a question.
>
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVF
ObjC.h:39
> +class InbandChapterTrackPrivateAVFObjC : public InbandTextTrackPrivate {
Nit: final.
>
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVF
ObjC.h:51
> + int trackIndex() const override { return m_index; }
Ditto.
>
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVF
ObjC.h:59
> + AtomString inBandMetadataTrackDispatchType() const override { return
"com.apple.chapters"_s; }
Ditto.
>
Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVF
ObjC.mm:74
> + [item loadValuesAsynchronouslyForKeys:@[@"value"]
completionHandler:[this, protectedThis = Ref { *this }, item = retainPtr(item),
createChapterCue = WTFMove(createChapterCue), chapterNumber, identifier] ()
mutable {
WTFMove(createChapterCue) seems really weird here; won't that mean only the
first iteration through the for loop has a valid lambda?
More information about the webkit-reviews
mailing list