[webkit-reviews] review granted: [Bug 230864] Speed up setting JSFunction's "prototype" property : [Attachment 439403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 18:32:22 PDT 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 230864: Speed up setting JSFunction's "prototype" property
https://bugs.webkit.org/show_bug.cgi?id=230864

Attachment 439403: Patch

https://bugs.webkit.org/attachment.cgi?id=439403&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 439403
  --> https://bugs.webkit.org/attachment.cgi?id=439403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439403&action=review

r=me

> Source/JavaScriptCore/runtime/JSFunction.cpp:299
> +constexpr unsigned prototypeAttributesForNonClass =
PropertyAttribute::DontEnum | PropertyAttribute::DontDelete;

Let's put `static` too.


More information about the webkit-reviews mailing list