[webkit-reviews] review granted: [Bug 230853] Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h : [Attachment 439401] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 230853: Build-time optimization: forward declare more things in
MediaPlayer.h and HTMLMediaElement.h
https://bugs.webkit.org/show_bug.cgi?id=230853

Attachment 439401: Patch

https://bugs.webkit.org/attachment.cgi?id=439401&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 439401
  --> https://bugs.webkit.org/attachment.cgi?id=439401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439401&action=review

r=me once the bots are happy

> Source/WebCore/ChangeLog:73
> +	   * html/track/VideoTrackClient.h: Copied from
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Nit: you should probably remove the auto-generated "Copied from
Source/WebCore/Modules..." message as it isn't helpful.

> Source/WebCore/ChangeLog:85
> +	   * platform/graphics/AudioTrackPrivateClient.h: Copied from
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.

> Source/WebCore/ChangeLog:94
> +	   * platform/graphics/TrackPrivateBaseClient.h: Copied from
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.

> Source/WebCore/ChangeLog:98
> +	   * platform/graphics/VideoTrackPrivateClient.h: Copied from
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.