[webkit-reviews] review granted: [Bug 230839] PCM: different bundleID entries will override each other : [Attachment 439387] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 230839: PCM: different bundleID entries will override each other
https://bugs.webkit.org/show_bug.cgi?id=230839

Attachment 439387: Patch

https://bugs.webkit.org/attachment.cgi?id=439387&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 439387
  --> https://bugs.webkit.org/attachment.cgi?id=439387
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439387&action=review

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:276
> +const Vector<String>& ResourceLoadStatisticsDatabaseStore::sortedTables()

This could be a std::array, which would not require any dynamic allocation.

> Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:199
> +	   RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::currentTableAndIndexQueries Unable to
prepare statement to fetch schema for the table, error message: %"
PRIVATE_LOG_STRING, this, m_database.lastErrorMsg());

DatabaseUtilities::
Also, I've been using the PrivateClickMeasurement logging channel in this file
even though it's shared with RLS.  Network isn't a great channel for this.
Ditto several times below.

> Source/WebKit/NetworkProcess/DatabaseUtilities.h:43
> +typedef std::pair<String, std::optional<String>> TableAndIndexPair;

using TableAndIndexPair = std::pair<String, std::optional<String>>;