[webkit-reviews] review granted: [Bug 230851] Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolutionCallback : [Attachment 439375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 12:01:10 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 230851: Rename Style::queuePostResolutionCallback to
Style::deprecatedQueuePostResolutionCallback
https://bugs.webkit.org/show_bug.cgi?id=230851

Attachment 439375: Patch

https://bugs.webkit.org/attachment.cgi?id=439375&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439375
  --> https://bugs.webkit.org/attachment.cgi?id=439375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439375&action=review

> Source/WebCore/style/StyleTreeResolver.h:115
> +void deprecatedQueuePostResolutionCallback(Function<void()>&&); // Integrate
with the HTML5 event loop instead.

I think this comment could be more helpful. Where in the code should I do stuff
instead of calling this function?


More information about the webkit-reviews mailing list