[webkit-reviews] review granted: [Bug 230580] [Cocoa] Add SPI to select a tab created by _WKInspectorExtension : [Attachment 439364] Patch v1.3 (rebase)

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 230580: [Cocoa] Add SPI to select a tab created by _WKInspectorExtension
https://bugs.webkit.org/show_bug.cgi?id=230580

Attachment 439364: Patch v1.3 (rebase)

https://bugs.webkit.org/attachment.cgi?id=439364&action=review




--- Comment #14 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 439364
  --> https://bugs.webkit.org/attachment.cgi?id=439364
Patch v1.3 (rebase)

View in context: https://bugs.webkit.org/attachment.cgi?id=439364&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:276
> +    // It is an error to call this method prior to creating a frontend
(i.e., with -connect or -show).

might be worth adding this to the header doc too?

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:282
> +   
_inspector->extensionController()->showExtensionTab(extensionTabIdentifier,
[protectedSelf = retainPtr(self), capturedBlock =
makeBlockPtr(completionHandler)] (Expected<bool, Inspector::ExtensionError>
result) mutable {

should `result` have a `&`?

btw are you sure that `Expected` doesn't work with `void`?  i see code that
should make it work ��

> Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:223
> +    // It is an error to call this method prior to creating a frontend
(i.e., with -connect or -show).

ditto

> Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:230
> +	   if (!result) {

ditto