[webkit-reviews] review granted: [Bug 230672] [MSE] appending to the source buffer will not throw when the source buffer is full. : [Attachment 439234] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 230672: [MSE] appending to the source buffer will not throw when the source
buffer is full.
https://bugs.webkit.org/show_bug.cgi?id=230672

Attachment 439234: Patch

https://bugs.webkit.org/attachment.cgi?id=439234&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 439234
  --> https://bugs.webkit.org/attachment.cgi?id=439234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439234&action=review

> Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:206
> +size_t PlatformTimeRanges::findWithFudge(const MediaTime& time, const
MediaTime& fudge)

I know we call the factor “fudge” in MSE code, but we use “epsilon” in the rest
of WebKit so I think it would be better to use that term in this class

> Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:216
> +PlatformTimeRanges PlatformTimeRanges::copyWithFudge(const MediaTime& fudge)
const

Ditto