[webkit-reviews] review canceled: [Bug 230776] IPC::Encoder::grow and IPC::Decoder::alignBufferPosition are incompatible when alignment != 8 : [Attachment 439241] With ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 26 17:16:45 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 230776: IPC::Encoder::grow and IPC::Decoder::alignBufferPosition are
incompatible when alignment != 8
https://bugs.webkit.org/show_bug.cgi?id=230776

Attachment 439241: With ChangeLog

https://bugs.webkit.org/attachment.cgi?id=439241&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 439241
  --> https://bugs.webkit.org/attachment.cgi?id=439241
With ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=439241&action=review

> Source/WebKit/Platform/IPC/Encoder.cpp:189
> +    size_t alignedSize = roundUpToMultipleOf(alignment, m_bufferSize);

I just realized that if we go this route, StreamConnectionEncoder is going to
also need this adjustment.


More information about the webkit-reviews mailing list