[webkit-reviews] review granted: [Bug 230801] [JSC] Optimize PutByVal with for-in : [Attachment 439293] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 26 09:29:59 PDT 2021

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 230801: [JSC] Optimize PutByVal with for-in

Attachment 439293: Patch


--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 439293
  --> https://bugs.webkit.org/attachment.cgi?id=439293

View in context: https://bugs.webkit.org/attachment.cgi?id=439293&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1503
> +    OpJeqPtr::emit(this, cond, moveLinkTimeConstant(nullptr,
LinkTimeConstant::sentinelString), target.bind(this));

No need for this to be a link time constant. It can live on UnlinkedCodeBlock.
It’s not related to global object.

More information about the webkit-reviews mailing list