[webkit-reviews] review granted: [Bug 230573] [Cocoa] backport showConsole() and showResources() for RemoteWebInspectorUI : [Attachment 438951] Patch v1.2

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 230573: [Cocoa] backport showConsole() and showResources() for
RemoteWebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=230573

Attachment 438951: Patch v1.2

https://bugs.webkit.org/attachment.cgi?id=438951&action=review




--- Comment #11 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 438951
  --> https://bugs.webkit.org/attachment.cgi?id=438951
Patch v1.2

View in context: https://bugs.webkit.org/attachment.cgi?id=438951&action=review

r=me based on described changes to API doc

>>> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorIBActions.h:46
>>> + * This will open the associated Web Inspector if it is not already open.
>> 
>> Is this actually true?
> 
> No. I have removed the comment in the newest patch version.
> 
> Most of the IBActions have no effect unless the inspector frontend is loaded.
Ultimately they will wait for frontend to finish loading in
InspectorFrontendAPIDispatcher.
> 
> It is recommended for API users to call -show before doing more things with
_WKInspector.

Gotcha.  That sounds fine :)