[webkit-reviews] review granted: [Bug 230565] Pending preconnect key should include User-Agent : [Attachment 438922] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ben Nham <nham at apple.com>'s request
for review:
Bug 230565: Pending preconnect key should include User-Agent
https://bugs.webkit.org/show_bug.cgi?id=230565

Attachment 438922: Patch

https://bugs.webkit.org/attachment.cgi?id=438922&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 438922
  --> https://bugs.webkit.org/attachment.cgi?id=438922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438922&action=review

r=me with changes.

> Source/WebKit/NetworkProcess/NetworkLoadScheduler.cpp:156
> +static std::tuple<String, String> mainResourceLoadKey(String
protocolHostAndPort, String userAgent)

`const String&` for both parameters to avoid ref-counting churn.

> Source/WebKit/NetworkProcess/NetworkLoadScheduler.h:54
> +    void startedPreconnectForMainResource(const URL&, const String&);

Please do not omit the second parameter name as it is not obvious what it is.

> Source/WebKit/NetworkProcess/NetworkLoadScheduler.h:55
> +    void finishedPreconnectForMainResource(const URL&, const String&, const
WebCore::ResourceError&);

ditto.

> Source/WebKit/NetworkProcess/NetworkLoadScheduler.h:81
> +    using PendingPreconnectMap = HashMap<std::tuple<String, String>,
PendingMainResourcePreconnectInfo>;

We probably want inline comments to indicate what those Strings are.