[webkit-reviews] review granted: [Bug 230724] [LFC][IFC] InlineLevelBox only needs a handful of style properties : [Attachment 439118] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 06:07:40 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 230724: [LFC][IFC] InlineLevelBox only needs a handful of style properties
https://bugs.webkit.org/show_bug.cgi?id=230724

Attachment 439118: Patch

https://bugs.webkit.org/attachment.cgi?id=439118&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 439118
  --> https://bugs.webkit.org/attachment.cgi?id=439118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439118&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:133
> +    struct Style {
> +	   const FontMetrics& primaryFontMetrics;
> +	   const Length& lineHeight;
> +	   InlineLayoutUnit primaryFontSize { 0 };
> +	   VerticalAlignment verticalAlignment { };
> +    };
> +    Style m_style;

Nice


More information about the webkit-reviews mailing list