[webkit-reviews] review granted: [Bug 229330] Implement hit testing bits of inert subtrees : [Attachment 439042] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 229330: Implement hit testing bits of inert subtrees
https://bugs.webkit.org/show_bug.cgi?id=229330

Attachment 439042: Patch

https://bugs.webkit.org/attachment.cgi?id=439042&action=review




--- Comment #13 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 439042
  --> https://bugs.webkit.org/attachment.cgi?id=439042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439042&action=review

> Source/WebCore/style/StyleAdjuster.cpp:526
> +    bool isInertSubtreeRoot = (m_document.activeModalDialog() && m_element
== m_document.documentElement())
> +	   || (m_document.settings().inertAttributeEnabled() &&
is<HTMLElement>(m_element) && m_element->hasAttribute(HTMLNames::inertAttr));

This would read better as a lambda.

> Source/WebCore/style/StyleAdjuster.cpp:532
> +    if (isInertSubtreeRoot)
> +	   style.setEffectiveInert(true);
> +
> +    // Make sure the active dialog is interactable when the whole document
is blocked by the modal dialog
> +    if (m_element == m_document.activeModalDialog())
> +	   style.setEffectiveInert(false);

What should happen when you have an active <dialog inert>?