[webkit-reviews] review granted: [Bug 227300] Mandatory scroll snapping doesn't work correctly in tables with position:sticky : [Attachment 439038] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 227300: Mandatory scroll snapping doesn't work correctly in tables with
position:sticky
https://bugs.webkit.org/show_bug.cgi?id=227300

Attachment 439038: Patch

https://bugs.webkit.org/attachment.cgi?id=439038&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439038
  --> https://bugs.webkit.org/attachment.cgi?id=439038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439038&action=review

You'll need to skip the test on iOS.

> Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:334
> +	   OptionSet<MapCoordinatesMode> options;
> +	   options.add(UseTransforms);
> +	   options.add(IgnoreStickyOffsets);

OptionSet<MapCoordinatesMode> options = { UseTransforms, IgnoreStickyOffsets };