[webkit-reviews] review granted: [Bug 230603] DOMPromiseDeferred should be able to handle Ref/RefPtr resolution values for interface types : [Attachment 438934] Patch

[bugzilla-daemon at webkit.org]

Sihui Liu <sihui_liu at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 230603: DOMPromiseDeferred should be able to handle Ref/RefPtr resolution
values for interface types
https://bugs.webkit.org/show_bug.cgi?id=230603

Attachment 438934: Patch

https://bugs.webkit.org/attachment.cgi?id=438934&action=review




--- Comment #3 from Sihui Liu <sihui_liu at apple.com> ---
Comment on attachment 438934
  --> https://bugs.webkit.org/attachment.cgi?id=438934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438934&action=review

Nice, r=me with nits.

> Source/WebCore/ChangeLog:10
> +	   Small refactring to use reject instead of settle in ApplePaySetup.

refactoring

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
90
> +    Function<void(ExceptionOr<Ref<RTCCertificate>>&&)> m_resultCallback;

Do we want Function or CompletionHandler (is this function called multiple
times)?
If we use Function, can we use std::exchange instead of WTFMove?