[webkit-reviews] review granted: [Bug 229792] <video> element rendered incorrectly when provided with a portrait orientation stream in Safari 15 : [Attachment 438972] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 229792: <video> element rendered incorrectly when provided with a portrait
orientation stream in Safari 15
https://bugs.webkit.org/show_bug.cgi?id=229792

Attachment 438972: Patch

https://bugs.webkit.org/attachment.cgi?id=438972&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 438972
  --> https://bugs.webkit.org/attachment.cgi?id=438972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438972&action=review

> Source/WebCore/ChangeLog:10
> +	   We also need to ompute m_sampleBufferDisplayLayer position based on
m_rootLayer coordinates.

s/ompute/compute/

> LayoutTests/fast/mediastream/video-rotation.html:22
> +    await new Promise(resolve => setTimeout(resolve, 3000));

This hard coded wait is unfortunate because it will almost always be way too
long, but it can presumably be too short on a very heavily loaded machine. Can
we avoid it by doing something like rendering to a canvas until we see that
someone has been rendered?