[webkit-reviews] review granted: [Bug 230331] Various tweaks in preparation for Temporal.Instant : [Attachment 438998] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 18:18:50 PDT 2021

Yusuke Suzuki <ysuzuki at apple.com> has granted Philip Chimento
<philip.chimento at gmail.com>'s request for review:
Bug 230331: Various tweaks in preparation for Temporal.Instant

Attachment 438998: Patch


--- Comment #13 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 438998
  --> https://bugs.webkit.org/attachment.cgi?id=438998

View in context: https://bugs.webkit.org/attachment.cgi?id=438998&action=review

r=me with comments

> Source/JavaScriptCore/runtime/TemporalDuration.cpp:122
> +	   copy.append(UChar { 0x2026 }); // U+2026 ellipsis

Use `horizontalEllipsis` in <wtf/unicode/CharacterNames.h>

> Source/JavaScriptCore/runtime/TemporalObject.cpp:254
> +	   throwRangeError(globalObject, scope,
makeString("fractionalSecondDigits must be 'auto' or 0 through 9, not "_s,

Also need to consider about super long string. So ellipsizeAt is necessary.

More information about the webkit-reviews mailing list