[webkit-reviews] review granted: [Bug 230652] [JSC] emoji and eor collations are missing : [Attachment 438989] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 230652: [JSC] emoji and eor collations are missing
https://bugs.webkit.org/show_bug.cgi?id=230652

Attachment 438989: Patch

https://bugs.webkit.org/attachment.cgi?id=438989&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 438989
  --> https://bugs.webkit.org/attachment.cgi?id=438989
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review

r=me with a question

> Source/JavaScriptCore/runtime/IntlObject.cpp:1661
> +    // ICU ~69 has a bug that does not report "emoji" and "eor" for
collation when using ucol_getKeywordValues.

There's no concern for older ICU versions here, is there?