[webkit-reviews] review granted: [Bug 230600] Web Inspector: add a pinned [+] button to the tab bar to make it easier to re-open closed tabs : [Attachment 438930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 08:52:57 PDT 2021


BJ Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 230600: Web Inspector: add a pinned [+] button to the tab bar to make it
easier to re-open closed tabs
https://bugs.webkit.org/show_bug.cgi?id=230600

Attachment 438930: Patch

https://bugs.webkit.org/attachment.cgi?id=438930&action=review




--- Comment #3 from BJ Burg <bburg at apple.com> ---
Comment on attachment 438930
  --> https://bugs.webkit.org/attachment.cgi?id=438930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438930&action=review

r=me

> Source/WebInspectorUI/ChangeLog:23
> +	   Drive-by: Remove `_handleTabContainerClick` as tabs can only be
removed from the contextmenu.

s/from/by using/

So in other words, this is dead code. Right? I wasn't able to trigger the
previous behavior of "option-click to delete" in a build without this change.


More information about the webkit-reviews mailing list