[webkit-reviews] review granted: [Bug 230597] [LFC][Integration] Remove ensureLineBoxes : [Attachment 438935] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 230597: [LFC][Integration] Remove ensureLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=230597

Attachment 438935: Patch

https://bugs.webkit.org/attachment.cgi?id=438935&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 438935
  --> https://bugs.webkit.org/attachment.cgi?id=438935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438935&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:-3905
> -    ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight));

The dreaded assert! I am not going to miss you.

> Source/WebCore/rendering/RenderBlockFlow.h:-368
> -    void ensureLineBoxes();
> -    void generateLineBoxTree();

end of an era.