[webkit-reviews] review granted: [Bug 230587] Remove ENABLE(SMOOTH_SCROLLING) : [Attachment 438914] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230587: Remove ENABLE(SMOOTH_SCROLLING)
https://bugs.webkit.org/show_bug.cgi?id=230587

Attachment 438914: Patch

https://bugs.webkit.org/attachment.cgi?id=438914&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 438914
  --> https://bugs.webkit.org/attachment.cgi?id=438914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438914&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:29
> -#if ENABLE(SMOOTH_SCROLLING)
> +#if PLATFORM(MAC)

Kinda feel like semantic flags are better than PLATFORM() ones (but also that
ENABLE(SMOOTH_SCROLLING) is meaningless so maybe this one is not a good example
:D)