[webkit-reviews] review granted: [Bug 230592] Add FontCreationContext : [Attachment 438906] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Myles C. Maxfield <mmaxfield at apple.com>'s
request for review:
Bug 230592: Add FontCreationContext
https://bugs.webkit.org/show_bug.cgi?id=230592

Attachment 438906: Patch

https://bugs.webkit.org/attachment.cgi?id=438906&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 438906
  --> https://bugs.webkit.org/attachment.cgi?id=438906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438906&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:579
> -    auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault,
2, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +    auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault,
0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));

TIL Pass 0 to specify that the maximum capacity is not limited.