[webkit-reviews] review granted: [Bug 230582] [JSC] CompareStrictEq is omitting String check incorrectly : [Attachment 438879] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 230582: [JSC] CompareStrictEq is omitting String check incorrectly
https://bugs.webkit.org/show_bug.cgi?id=230582

Attachment 438879: Patch

https://bugs.webkit.org/attachment.cgi?id=438879&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 438879
  --> https://bugs.webkit.org/attachment.cgi?id=438879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383
>      JITCompiler::JumpList trueCase;

Not due to your patch, but the comment above is incorrect: `if (left == true)
{` ==> `if (left == right) {`