[webkit-reviews] review granted: [Bug 230394] Parsing support for font-palette : [Attachment 438852] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 230394: Parsing support for font-palette
https://bugs.webkit.org/show_bug.cgi?id=230394

Attachment 438852: Patch

https://bugs.webkit.org/attachment.cgi?id=438852&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 438852
  --> https://bugs.webkit.org/attachment.cgi?id=438852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438852&action=review

> Source/WebCore/platform/graphics/FontCache.h:160
> +	       if (!m_rareData && !other.m_rareData)
> +		   return true;
> +	       return m_rareData && other.m_rareData && *m_rareData ==
*other.m_rareData;

arePointingToEqualData()?

> Source/WebCore/platform/graphics/FontPalette.h:37
> +	   return type == other.type;

Shouldn't this compare the identifier if custom?

> Source/WebCore/platform/graphics/FontPalette.h:45
> +    enum class Type {

: unit8_t?

Won't help with padding here though, but it might shrink IPC.

>
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached
-subtree-expected.txt:6
> +FAIL getComputedStyle returns no style for element in non-rendered iframe
(display: none) assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for element in non-rendered iframe
(display: none) from iframe's window assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for element outside the flat tree
assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for descendant outside the flat tree
assert_equals: expected 0 but got 394

You'll need iOS results for these.