[webkit-reviews] review granted: [Bug 230245] [bmalloc] freeableMemory and footprint of Heap are broken : [Attachment 438316] patch again.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 13:21:37 PDT 2021


Geoffrey Garen <ggaren at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 230245: [bmalloc] freeableMemory and footprint of Heap are broken
https://bugs.webkit.org/show_bug.cgi?id=230245

Attachment 438316: patch again.

https://bugs.webkit.org/attachment.cgi?id=438316&action=review




--- Comment #11 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 438316
  --> https://bugs.webkit.org/attachment.cgi?id=438316
patch again.

View in context: https://bugs.webkit.org/attachment.cgi?id=438316&action=review

r=me

> Source/bmalloc/ChangeLog:3
> +	   [bmalloc] freeableMemory and footprint of Heap are broken

Can you make this title more precise? Are freeableMemory and footprint
literally completely broken in all cases all the time, or only in certain
cases, or only broken in a particular way?

Can you say anything about how observable behavior changes after this change is
made?


More information about the webkit-reviews mailing list