[webkit-reviews] review denied: [Bug 230552] NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly : [Attachment 438818] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 230552: NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP
addresses correctly
https://bugs.webkit.org/show_bug.cgi?id=230552

Attachment 438818: Patch

https://bugs.webkit.org/attachment.cgi?id=438818&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438818
  --> https://bugs.webkit.org/attachment.cgi?id=438818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438818&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:154
> +#if USE(APPLE_INTERNAL_SDK)

I think it would be better to add NetworkSPI.h rather than have different
behavior like this only in internal builds.  That is what our SPI headers are
for.