[webkit-reviews] review granted: [Bug 230399] imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html is flaky : [Attachment 438659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 07:57:59 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 230399: imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html is
flaky
https://bugs.webkit.org/show_bug.cgi?id=230399

Attachment 438659: Patch

https://bugs.webkit.org/attachment.cgi?id=438659&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 438659
  --> https://bugs.webkit.org/attachment.cgi?id=438659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438659&action=review

> Source/WebCore/ChangeLog:11
> +	   - We were creating the data channel handler at the time we were
creating the data channel handler.

S/creating the data channel handler at the time/creating the data channel at
the time/

> Source/WebCore/ChangeLog:18
> +	   Covered by test no longer flaky.

and by updated test RTCDataChannel-close.html.


More information about the webkit-reviews mailing list