[webkit-reviews] review granted: [Bug 230506] Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for scroll snap : [Attachment 438752] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230506: Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when
used for scroll snap
https://bugs.webkit.org/show_bug.cgi?id=230506

Attachment 438752: Patch

https://bugs.webkit.org/attachment.cgi?id=438752&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 438752
  --> https://bugs.webkit.org/attachment.cgi?id=438752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438752&action=review

> Source/WebCore/platform/ScrollAnimationMomentum.cpp:104
> +    auto predictedScrollOffset =
m_momentumCalculator->predictedDestinationOffset();

Is `m_momentumCalculator` guaranteed to be non-null here because this should
only be called for active animations?