[webkit-reviews] review granted: [Bug 230495] [Cocoa] Videos sometimes don't render when loaded in the GPU process : [Attachment 438717] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 230495: [Cocoa] Videos sometimes don't render when loaded in the GPU
process
https://bugs.webkit.org/show_bug.cgi?id=230495

Attachment 438717: Patch

https://bugs.webkit.org/attachment.cgi?id=438717&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 438717
  --> https://bugs.webkit.org/attachment.cgi?id=438717
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438717&action=review

r=me with nits:

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:244
> +    ALWAYS_LOG(LOGIDENTIFIER);

Maybe, `ALWAYS_LOG(LOGIDENTIFIER, visible)` ?

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:356
> +    ALWAYS_LOG(LOGIDENTIFIER);

Maybe, `ALWAYS_LOG(LOGIDENTIFIER, m_player->readyState())` ?