[webkit-reviews] review granted: [Bug 230477] Disable FTP : [Attachment 438680] v4

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 230477: Disable FTP
https://bugs.webkit.org/show_bug.cgi?id=230477

Attachment 438680: v4

https://bugs.webkit.org/attachment.cgi?id=438680&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 438680
  --> https://bugs.webkit.org/attachment.cgi?id=438680
v4

View in context: https://bugs.webkit.org/attachment.cgi?id=438680&action=review

r=me

Seems fine. Please rename the setting before landing.

EWS failure seems pre-existing.

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:424
> +FTPDisabled:

I prefer settings to be nouns or affirmative phrases. That way, we can avoid
the double negative of talking about when "ftp disabling is disabled". Let's
call this just FTP or FTPEnabled or FTPSupport.