[webkit-reviews] review granted: [Bug 230424] [Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature : [Attachment 438624] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 08:51:32 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 230424: [Cocoa] Make AVSampleBufferVideoOutput support an Experimental
Feature
https://bugs.webkit.org/show_bug.cgi?id=230424

Attachment 438624: Patch

https://bugs.webkit.org/attachment.cgi?id=438624&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 438624
  --> https://bugs.webkit.org/attachment.cgi?id=438624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438624&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:920
> +    return MediaSessionManagerCocoa::mediaSourceInlinePaintingEnabled() &&
PAL::getAVSampleBufferVideoOutputClass;

Shouldn't this be `PAL::getAVSampleBufferVideoOutputClass()`?


More information about the webkit-reviews mailing list